Conversation
Hopefully fixes intermittent test failure.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ingestion stack to support the icalendar gem bump and to improve ingestion robustness by reusing shared sitemap parsing and adjusting error handling, alongside a test-suite fix for intermittent failures caused by leaked Space.current_space.
Changes:
- Bump
icalendarto 2.12.2 (and related dependency updates) and adjust iCal ingestion/test expectations accordingly. - Reuse shared
SitemapHelpers#parse_sitemapin additional ingestors and standardize sitemap parsing behavior on failure. - Reset
Space.current_spacein test teardown to prevent cross-test state leakage.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/unit/ingestors/ical_ingestor_test.rb | Updates assertions to match new error/message behavior after sitemap/helper + open_url changes. |
| test/test_helper.rb | Clears Space.current_space in teardown to address intermittent failures due to leaked global state. |
| lib/ingestors/indico_ingestor.rb | Removes now-unnecessary nil-guard after sitemap parsing behavior change. |
| lib/ingestors/ical_ingestor.rb | Switches to shared sitemap parsing and removes broad exception swallowing in iCal processing. |
| lib/ingestors/concerns/sitemap_helpers.rb | Adjusts parse contract to return [] on sitemap parse errors and narrows rescued exception type. |
| lib/ingestors/bioschemas_ingestor.rb | Replaces local sitemap parsing with shared SitemapHelpers. |
| Gemfile.lock | Locks icalendar 2.12.2 (plus dependency changes like ice_cube 0.17.0). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
icalendarversion and fixes test failure.Motivation and context
#1264
Intermittent test failure: https://github.com/ElixirTeSS/TeSS/actions/runs/24051302878/job/70147312648#step:9:43
Checklist